Conversation
nightwing
reviewed
Feb 24, 2025
src/block-cursor.ts
Outdated
| style.fontFamily, style.fontSize, style.fontWeight, style.color, | ||
| primary ? "cm-fat-cursor cm-cursor-primary" : "cm-fat-cursor cm-cursor-secondary", | ||
| letter, hCoeff != 1) | ||
| return new Piece(left - base.left, pos.top - base.top + h * (1 - hCoeff), h * hCoeff, style.fontFamily, parseFloat(style.fontSize) * view.scaleX + "px", style.fontWeight, style.color, primary ? "cm-fat-cursor cm-cursor-primary" : "cm-fat-cursor cm-cursor-secondary", letter, hCoeff != 1) |
Collaborator
There was a problem hiding this comment.
Could you please keep the old formatting for readability.
As for parseFloat(style.fontSize) * view.scaleX, this does not work when scaleX and scaleY are different, and when they are the same, it still causes small mismatch in the appearance of letter inside cursor and inside the editor, so i think we need to find a different way of applying the scale. E.g. maybe we can skip applying the transform online 97 and change the way we calculate sizes?
nightwing
reviewed
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for css scaling for BlockCursor based on this commit
Everything works as expected...
scaling.mp4
... except font scaling. I'm not sure what the correct way to scale the font would be.